Skip to content

Conversation

@rtibbles
Copy link
Member

@rtibbles rtibbles commented Nov 27, 2025

Summary

Adds context aware error messaging to plugin enable and apply to give information about pex plugin enabling
Adds developer documentation about the same.

References

Fixes #6516

Reviewer guidance

Try to enable a non-existent plugin with the pex file - see the error message!

🤖 This was created by Claude Code. @rtibbles then reviewed the generated output, and did iterative rounds of updates before making it ready for review 🤖

@github-actions github-actions bot added SIZE: small DEV: backend Python, databases, networking, filesystem... and removed SIZE: small labels Nov 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting PEX_INHERIT_PATH to 1 is not a valid option.

@rtibbles
Copy link
Member Author

rtibbles commented Dec 9, 2025

So much for trusting the issue!

@rtibbles
Copy link
Member Author

rtibbles commented Dec 9, 2025

Looks like fallback is probably the best value.

@rtibbles
Copy link
Member Author

rtibbles commented Dec 9, 2025

Although.. weirdly that doesn't seem to work.

@rtibbles
Copy link
Member Author

rtibbles commented Dec 9, 2025

Oh, no, it does! Nevermind - updating!

@rtibbles rtibbles force-pushed the claude/plan-issue-6516-01CS8mX36QyzvNmtFN2B1aTj branch from 577b0ce to d48ee62 Compare December 9, 2025 20:36
@rtibbles
Copy link
Member Author

rtibbles commented Dec 9, 2025

Updated to PEX_INHERIT_PATH=fallback, which does seem to work - I guess the 1 value was from pex v1, which we dropped when we dropped Python 2.7 support.

@rtibbles
Copy link
Member Author

rtibbles commented Dec 9, 2025

Verified here for the version of pex we are using, as a reference: https://github.com/pex-tool/pex/blob/v2.1.153/pex/variables.py#L487

@bjester
Copy link
Member

bjester commented Dec 9, 2025

Yeah fallback seems most appropriate. I will test it to double check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV: backend Python, databases, networking, filesystem... SIZE: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when we document kolibri plugin enable | disable, ensure that PEX has special note

3 participants